Repository navigation
docs(wish): promotion sequence without #2833; record staging-leak follow-up and dogfood evidence - #2840
Conversation
…low-up and dogfood evidence Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40187bbb35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Poured | ||
|
|
||
| - [genie-dual-mode-orca-plugin — DESIGN](brainstorms/genie-dual-mode-orca-plugin/DESIGN.md) → [WISH](wishes/genie-dual-mode-orca-plugin/WISH.md) — **IN_PROGRESS** (plan APPROVED/SHIP 2026-08-29 design digest `2499668e…`; A1–A7 merged to dev #2808–#2820). Rolling promotion #2817 dev→main: review #0 at `eccf0ae4a` FIX-FIRST (6 HIGH, 0 CRITICAL) → fixes #2821/#2823/#2824/#2825/#2826/#2827/#2829/#2830/#2834 merged; re-review #1 at `f45d634b8` FIX-FIRST (all prior HIGHs closed, 3983 tests pass; one new HIGH H7 — SessionStart hook opened genie.db under Orca authority → #2835; M12/M15 → #2836). Main-side hotfixes awaiting human merge: #2822 (ninth version field), #2833 (dogfood harness accepts retired Codex route — why v5.260830.x never published). re-review #2 at `0d0641f97` **SHIP** (0 CRITICAL/HIGH, 3984 tests pass; M16/M17 non-blocking → #2838). **Approved for human promotion**: merge #2822 + #2833 to main first, then #2817 with a merge commit; follow-ups M2/M3/M4/M9/M10 recorded in WISH.md. Also fixed outside wish scope: `tar -xzf` without `-p` broke `genie update` under umask 077 (#2821/#2824) | ||
| - [genie-dual-mode-orca-plugin — DESIGN](brainstorms/genie-dual-mode-orca-plugin/DESIGN.md) → [WISH](wishes/genie-dual-mode-orca-plugin/WISH.md) — **IN_PROGRESS** (plan APPROVED/SHIP 2026-08-29 design digest `2499668e…`; A1–A7 merged to dev #2808–#2820). Rolling promotion #2817 dev→main: review #0 at `eccf0ae4a` FIX-FIRST (6 HIGH, 0 CRITICAL) → fixes #2821/#2823/#2824/#2825/#2826/#2827/#2829/#2830/#2834 merged; re-review #1 at `f45d634b8` FIX-FIRST (all prior HIGHs closed, 3983 tests pass; one new HIGH H7 — SessionStart hook opened genie.db under Orca authority → #2835; M12/M15 → #2836). Main-side hotfixes awaiting human merge: #2822 (ninth version field), #2833 (dogfood harness accepts retired Codex route — why v5.260830.x never published). re-review #2 at `0d0641f97` **SHIP** (0 CRITICAL/HIGH, 3984 tests pass; M16/M17 non-blocking → #2838). **Approved for human promotion**: merge #2822 to main first, then #2817 with a merge commit (#2833 closed — the promotion carries the harness); follow-ups M2/M3/M4/M9/M10 recorded in WISH.md. Also fixed outside wish scope: `tar -xzf` without `-p` broke `genie update` under umask 077 (#2821/#2824) |
There was a problem hiding this comment.
The same updated index entry still labels #2833 as a main-side hotfix “awaiting human merge,” but later instructs the promoter that #2833 is closed and must not be merged separately. An operator using this canonical summary therefore receives two incompatible promotion sequences; remove #2833 from the earlier outstanding-hotfix clause as well.
Useful? React with 👍 / 👎.
| failed admission leaves a ~100 MB `$GENIE_HOME/bin/.install-staging-<uuid>` behind (six on khal-labs, removed by | ||
| hand): `admitExternalInstallStaging`'s failure path does not reliably reach `removeInstallStagingDirectory`; needs | ||
| a regression fixture on the digest-mismatch branch. On-host dogfood evidence: `(umask 022 && genie update --dev |
There was a problem hiding this comment.
On the cited digest-mismatch path, admitExternalInstallStaging always reaches removeInstallStagingDirectory in its catch block (src/lib/install-promotion.ts:820-823). The leak occurs because that remover explicitly removes only an empty directory, while admission has already copied the payload into it. Recording this as an unreliable call path can send the follow-up toward adding another call that still cannot delete the populated stage; document the required safe populated-stage cleanup instead.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3
* ci(commitlint): pin the four #2817 review-wave squash subjects Three squash-merge headers (#2828, #2829, #2837) crossed 100 characters only because GitHub appended the PR suffix, and #2830's subject is capitalised ("Orca-mode"). They are already on shared dev, so — matching every prior exception in this file — pin the exact full subjects instead of rewriting history. The rolling promotion #2817 fails Commit Messages on that range until this lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3 * ci(commitlint): also pin the #2840 squash subject Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3 --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Ledger only (
.genie/): #2833 closed (onmainthe #2820 harness rejectsmain's own binary; the promotion #2817 carries it), so the human sequence is merge #2822 → merge #2817 (merge commit). Records the on-host dogfood evidence ((umask 022 && genie update --dev --yes)5.260816.2 → 5.260829.4 OK on khal-labs) and a new follow-up: failed admissions leave ~100 MB.install-staging-<uuid>dirs behind.wishes:lintOK.🤖 Generated with Claude Code
https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg